fixing database accesses

This commit is contained in:
Thomas Weinhold 2020-09-25 23:38:55 +02:00
commit b4e6c2f9bb
5 changed files with 40 additions and 37 deletions

View file

@ -6,8 +6,8 @@
if (!$GlobalMysqlHandler) if (!$GlobalMysqlHandler)
{ {
$err_msg = "Cannot connect to mysql database \"$GlobalMysqlHost\" as \"$GlobalMysqlUser\"!"; $err_msg = "Cannot connect to mysql database \"$GlobalMysqlHost\" as \"$GlobalMysqlUser\"!";
$err_msg += "\nErrno: " . mysqli_connect_errno(); $err_msg .= "\nErrno: " . mysqli_connect_errno();
$err_msg += "\nError: " . mysqli_connect_error(); $err_msg .= "\nError: " . mysqli_connect_error();
ErrorLog($err_msg); ErrorLog($err_msg);
$MysqlErrorsArePresent = 1; $MysqlErrorsArePresent = 1;
} }
@ -16,8 +16,8 @@
if (!mysqli_select_db($GlobalMysqlHandler, $GlobalMysqlDatabase)) if (!mysqli_select_db($GlobalMysqlHandler, $GlobalMysqlDatabase))
{ {
$err_msg = "Cannot select mysql database \"$GlobalMysqlDatabase\"!"; $err_msg = "Cannot select mysql database \"$GlobalMysqlDatabase\"!";
$err_msg += "\nErrno: " . mysqli_connect_errno(); $err_msg .= "\nErrno: " . mysqli_connect_errno();
$err_msg += "\nError: " . mysqli_connect_error(); $err_msg .= "\nError: " . mysqli_connect_error();
ErrorLog($err_msg); ErrorLog($err_msg);
$MysqlErrorsArePresent = 2; $MysqlErrorsArePresent = 2;
} }

View file

@ -85,16 +85,16 @@ if (UserGetLogin()=="root")
mysqli_query($CheckHandler, 'ALTER TABLE `Types` DROP PRIMARY KEY , ADD PRIMARY KEY ( `Id` )'); mysqli_query($CheckHandler, 'ALTER TABLE `Types` DROP PRIMARY KEY , ADD PRIMARY KEY ( `Id` )');
mysqli_query($CheckHandler, 'ALTER TABLE `Types` CHANGE `Id` `Id` INT( 11 ) NOT NULL AUTO_INCREMENT '); mysqli_query($CheckHandler, 'ALTER TABLE `Types` CHANGE `Id` `Id` INT( 11 ) NOT NULL AUTO_INCREMENT ');
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `Name` varchar(100) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `Name` varchar(100) COLLATE utf8_unicode_ci NOT NULL');
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `ShortName` varchar(10) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `ShortName` varchar(10) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `NameValue1` varchar(50) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `NameValue1` varchar(50) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `UnitValue1` varchar(20) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `UnitValue1` varchar(20) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `NameValue2` varchar(50) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `NameValue2` varchar(50) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `UnitValue2` varchar(20) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `UnitValue2` varchar(20) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `NameValue3` varchar(50) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `NameValue3` varchar(50) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `UnitValue3` varchar(20) COLLATE utf8_unicode_ci NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `UnitValue3` varchar(20) COLLATE utf8_unicode_ci NOT NULL DEFAULT ''");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `ParentId` int(11) NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `ParentId` int(11) NOT NULL");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `LockId` int(11) NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `LockId` int(11) NOT NULL DEFAULT '0'");
mysqli_query($CheckHandler, 'ALTER TABLE `Types` ADD `LockTime` int(11) NOT NULL'); mysqli_query($CheckHandler, "ALTER TABLE `Types` ADD `LockTime` int(11) NOT NULL DEFAULT '0'");
//User //User
mysqli_query($CheckHandler, 'CREATE TABLE IF NOT EXISTS `User` ( `Id` int(11) NOT NULL AUTO_INCREMENT, PRIMARY KEY (`Id`) ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; '); mysqli_query($CheckHandler, 'CREATE TABLE IF NOT EXISTS `User` ( `Id` int(11) NOT NULL AUTO_INCREMENT, PRIMARY KEY (`Id`) ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; ');
mysqli_query($CheckHandler, 'ALTER TABLE `User` ADD `Id` int(11) NOT NULL AUTO_INCREMENT'); mysqli_query($CheckHandler, 'ALTER TABLE `User` ADD `Id` int(11) NOT NULL AUTO_INCREMENT');

View file

@ -200,12 +200,15 @@ if (UserHasRight('EditTypes'))
{ {
global $GlobalMysqlHandler; global $GlobalMysqlHandler;
$InsertQuery="INSERT INTO `Types` (`Name`, `ParentId`) VALUES ( '$NewTypeName', '$ParentId');"; $InsertQuery="INSERT INTO `Types` (`Name`, `ParentId`) VALUES ( '$NewTypeName', '$ParentId');";
if (mysqli_query($GlobalMysqlHandler, $InsertQuery)) $QueyResult = mysqli_query($GlobalMysqlHandler, $InsertQuery);
{ if ($QueyResult === True) {
MessageSuccess(LangSpell('EditTypesNewTypeAdded')); MessageSuccess(LangSpell('EditTypesNewTypeAdded'));
} } else {
else $err_msg = "Cannot create new type!";
{ $err_msg .= "\nErrno: " . mysqli_connect_errno();
$err_msg .= "\nError: " . mysqli_connect_error();
$err_msg .= "\nQuery: " . $InsertQuery;
ErrorLog($err_msg);
MessageError(LangSpell('SentenceDatabaseError')); MessageError(LangSpell('SentenceDatabaseError'));
} }
} }

View file

@ -88,8 +88,8 @@ if (UserHasRight('EditVendors'))
$InsertVendorQuery = "INSERT INTO `Vendors` (`Name`, `Homepage`, `MinBill`, `ShippingCost`, `LockId`, `LockTime`) VALUES ('$Name', '$Homepage', '$MinBill', '$ShippingCost', 0, 0);"; $InsertVendorQuery = "INSERT INTO `Vendors` (`Name`, `Homepage`, `MinBill`, `ShippingCost`, `LockId`, `LockTime`) VALUES ('$Name', '$Homepage', '$MinBill', '$ShippingCost', 0, 0);";
if (mysqli_query($GlobalMysqlHandler, $InsertVendorQuery) === false) { if (mysqli_query($GlobalMysqlHandler, $InsertVendorQuery) === false) {
$err_msg = "Database error while insert new vendor!"; $err_msg = "Database error while insert new vendor!";
$err_msg += "\nErrno: " . mysqli_connect_errno(); $err_msg .= "\nErrno: " . mysqli_connect_errno();
$err_msg += "\nError: " . mysqli_connect_error(); $err_msg .= "\nError: " . mysqli_connect_error();
ErrorLog($err_msg); ErrorLog($err_msg);
MessageError(LangSpell('SentenceDatabaseError')); MessageError(LangSpell('SentenceDatabaseError'));
} else { } else {